RFR: 8229887: ZIP FS cannot replace an entry in a that was added via the STORED method

[Langer, Christoph]

Hi Lance, Alan,

would you mind if I take care of backporting this fix to jdk13u and jdk11u?

Thanks
Christoph

From: nio-dev <nio-dev-bounces at openjdk.java.net> On Behalf Of Lance Andersen
Sent: Mittwoch, 21. August 2019 16:46
To: Alan Bateman <Alan.Bateman at oracle.com>
Cc: nio-dev <nio-dev at openjdk.java.net>
Subject: Re: RFR: 8229887: ZIP FS cannot replace an entry in a that was added via the STORED method


On Aug 20, 2019, at 7:34 AM, Alan Bateman <Alan.Bateman at oracle.com<mailto:Alan.Bateman at oracle.com>> wrote:

On 19/08/2019 21:48, Lance Andersen wrote:

Hi

The following patch for JDK-8229887<https://bugs.openjdk.java.net/browse/JDK-8229887> addresses an issue introduced by the performance fix in https://bugs.openjdk.java.net/browse/JDK-8222532 resulting in an error when trying to replace an entry in a ZIP/JAR file that was added with no-compression.

The webrev can be found at http://cr.openjdk.java.net/~lancea/8229887/webrev.00/index.html

The update to ZipFileSystem looks good.

Thank you Alan


I think the test needs a bit of work and needs to test updating zip files where all entries are stored, all entries are deflated, and a mix of the two. I've created a test that does this if you need it.

A revised webrev can be found at: http://cr.openjdk.java.net/~lancea/8229887/webrev.01/index.html

This cleans up the existing test and adds some additional tests that were contributed by Alan.

Mach5 tier1-3 are all clean

Best
Lance



-Alan

[cid:image001.gif at 01D5629C.097DB070]<http://oracle.com/us/design/oracle-email-sig-198324.gif>

<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com<mailto:Lance.Andersen at oracle.com>




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190903/4e18bd09/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 658 bytes
Desc: image001.gif
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190903/4e18bd09/image001-0001.gif>