8229280: Test failures on several linux hosts after JDK-8181493

Langer, Christoph christoph.langer at sap.com
Fri Sep 6 06:24:31 UTC 2019


Hi Brian,

thanks for fixing this. Unfortunately I have been a bit out of game here for the review due to vacation and other stuff but it all seems to make sense to me ��

I’ve just re-enabled the test in our system. I’d let you know in case there were still issues.

Thanks
Christoph


From: nio-dev <nio-dev-bounces at openjdk.java.net> On Behalf Of Brian Burkhalter
Sent: Mittwoch, 4. September 2019 22:05
To: Alan Bateman <Alan.Bateman at oracle.com>
Cc: nio-dev <nio-dev at openjdk.java.net>
Subject: Re: 8229280: Test failures on several linux hosts after JDK-8181493


On Sep 4, 2019, at 12:24 PM, Alan Bateman <Alan.Bateman at oracle.com<mailto:Alan.Bateman at oracle.com>> wrote:

On 04/09/2019 20:09, Brian Burkhalter wrote:


Here is an updated version which should address the foregoing problems:

http://cr.openjdk.java.net/~bpb/8229280/webrev.02/
Good, this is much easier to maintain.

A minor nit is that the testedTypes should be a Set<String> to avoid the raw type warning. Also if you allow the lines to be just a bit longer then it would avoid the awkward line breaks at L46, 48, 52, and 65.

I have applied the foregoing changes at http://cr.openjdk.java.net/~bpb/8229280/webrev.03/.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190906/fb98df7f/attachment.html>


More information about the nio-dev mailing list