[11u] RFR: 8229887: (zipfs) zip file corruption when replacing an existing STORED entry

Langer, Christoph christoph.langer at sap.com
Fri Sep 6 09:35:12 UTC 2019


Hi,

> > Bug: https://bugs.openjdk.java.net/browse/JDK-8229887
> > Original Change: https://hg.openjdk.java.net/jdk/jdk/rev/abf6ee4c477c
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8229887.11u.0/
> 
> Backport looks good.

Thanks for reviewing this.

> > The original patch applies cleanly but the method java.nio.file.FileSystems::newFileSystem(Path
> > path) that is used in the test was only introduced in JDK13. So I have to fallback to
> > java.nio.file.FileSystems:: newFileSystem(Path path, ClassLoader loader) at these places (lines
> > 123, 163 and 195 of UpdateEntryTest). With this modification, the test passes.
> Have you tried if the new test fails without the product patch?

Yes, I have. The failure can be reproduced.

Will push it to jdk11u then.

Best regards
Christoph



More information about the nio-dev mailing list