[11u] RFR: 8229887: (zipfs) zip file corruption when replacing an existing STORED entry

Hohensee, Paul hohensee at amazon.com
Fri Sep 6 18:03:27 UTC 2019


Looks good.

Paul

On 9/5/19, 3:28 AM, "jdk-updates-dev on behalf of Langer, Christoph" <jdk-updates-dev-bounces at openjdk.java.net on behalf of christoph.langer at sap.com> wrote:

    Hi,
    
    may I please get a review for the backport of this item to jdk11 updates:
    Bug: https://bugs.openjdk.java.net/browse/JDK-8229887
    Original Change: https://hg.openjdk.java.net/jdk/jdk/rev/abf6ee4c477c
    Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8229887.11u.0/
    
    The original patch applies cleanly but the method java.nio.file.FileSystems::newFileSystem(Path path) that is used in the test was only introduced in JDK13. So I have to fallback to java.nio.file.FileSystems:: newFileSystem(Path path, ClassLoader loader) at these places (lines 123, 163 and 195 of UpdateEntryTest). With this modification, the test passes.
    
    Thanks
    Christoph
    
    



More information about the nio-dev mailing list