RFR: 8229872: (fs) Increase buffer size used with getmntent
Alan Bateman
Alan.Bateman at oracle.com
Sun Sep 8 07:49:55 UTC 2019
On 06/09/2019 14:59, Vladimir Kempik wrote:
> Hello
>
> Thanks for comments
>
> updated webrev including all mentioned things.
>
> http://cr.openjdk.java.net/~vkempik/8229872/webrev.08/
>
I think this is getting better. One thing that would help is a pointer
to documentation that confirms that getmntent_r may realloc buf as I
don't see this in the man page.
Some specific comments on webrev.08
LinuxFileSystem.java L98 - this sets buflen to maxLineSize before
incrementing maxLineSize, should be "buflen = maxLineSize + 1". I'm also
wondering if maxLineSize should be an int rather than a long as the
native code has to cast it to a size_t or native int.
LinuxNativeDispatcher.c - I would prefer not to have both buflen and
bufLen. No one type will work for all cases so I think you have to case
to size_t for malloc and int for getmntent_r.
-Alan
More information about the nio-dev
mailing list