8230085: (fs) FileStore::isReadOnly is always true on macOS Catalina

[Brian Burkhalter]

> On Sep 13, 2019, at 9:46 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 13/09/2019 15:42, Brian Burkhalter wrote:
>> :
>> 
>> One question is whether f_mntonname should also be used in creating the list of FileStores.
>> 
> Can you elaborate on this question? When the underlying file systems are enumerated with getfsstat then the BsdFileStore instances will be created with the dir field set to mount point (f_mntonname). So it should be used already.

That is correct - BsdNativeDispatcher.c:

    dir = iter->buf[iter->pos].f_mntonname;

[…]

    len = strlen(dir);
    bytes = (*env)->NewByteArray(env, len);
    if (bytes == NULL)
        return -1;
    (*env)->SetByteArrayRegion(env, bytes, 0, len, (jbyte*)dir);
    (*env)->SetObjectField(env, entry, entry_dir, bytes);

My comment was mostly a reminder to myself to double check this code. So I think the list of entries is already OK.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190913/b0b0313a/attachment.html>