RFR 8230870: Add a ZIP FS test that is similar to test/jdk/java/util/zip/EntryCount64k.java

[Langer, Christoph]

Hi Lance,

I looked at the test and also executed it and checked its output. Looks good to me, no comments ��

Best regards
Christoph

From: nio-dev <nio-dev-bounces at openjdk.java.net> On Behalf Of Lance Andersen
Sent: Mittwoch, 11. September 2019 19:23
To: nio-dev <nio-dev at openjdk.java.net>
Subject: RFR 8230870: Add a ZIP FS test that is similar to test/jdk/java/util/zip/EntryCount64k.java

Hi all,

Please review the addition of a ZIP FS test which is similar to test/jdk/java/util/zip/EntryCount64k.java

The test exercises the ZIP FS properties noCompression and forceZIP64End which we do not have much coverage for.

The test runs clean Mach5 and and I run it 100 times each on windows-x64, macosx-x64, linux-x64 and linux-x64-open platforms  to sanity check there are no potential timeout issues due to the test run

I have left some basic timing methods in the test but have disabled them in the unlikely event we have to revisit a timeout issue.

The webrev can be found at: http://cr.openjdk.java.net/~lancea/8230870/webrev.00/

Best
Lance
[cid:image001.gif at 01D56C75.5CE320A0]<http://oracle.com/us/design/oracle-email-sig-198324.gif>

<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com<mailto:Lance.Andersen at oracle.com>




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190916/7621fe8b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 658 bytes
Desc: image001.gif
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190916/7621fe8b/image001.gif>