RFR 8230870: Add a ZIP FS test that is similar to test/jdk/java/util/zip/EntryCount64k.java

[Martin Buchholz]

Thanks for doing this.
Looks Good To Me, but as always I have some comments

EntryCount64k was written before testng infrastructure was common.  I might
have done some surgery on EntryCount64k to accommodate zipfs instead of
writing an entirely new test.  zipfs adds to the number of ways that zip
files can be written - I generally only thought about ZipOutputStream.  One
can structure zip tests using front-end/back-end strategy:  Combine N ways
to write a zip file with M ways to read it, and verify that they all work
together.  But we've never written tests that way.

Stop using System.currentTimeMillis for measuring elapsed time, and switch
to System.nanoTime.  Hmmm .... probably even better here is to hop over
nanoTime to using java.time APIs like Duration.between as in
https://www.baeldung.com/java-measure-elapsed-time section 3.2

On Wed, Sep 11, 2019 at 10:26 AM Lance Andersen <lance.andersen at oracle.com>
wrote:

> Hi all,
>
> Please review the addition of a ZIP FS test which is similar
> to test/jdk/java/util/zip/EntryCount64k.java
>
> The test exercises the ZIP FS properties noCompression and forceZIP64End
> which we do not have much coverage for.
>
> The test runs clean Mach5 and and I run it 100 times each on windows-x64, macosx-x64,
> linux-x64 and linux-x64-open platforms  to sanity check there are
> no potential timeout issues due to the test run
>
> I have left some basic timing methods in the test but have disabled them
> in the unlikely event we have to revisit a timeout issue.
>
> The webrev can be found at:
> http://cr.openjdk.java.net/~lancea/8230870/webrev.00/
>
> Best
> Lance
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
> Principal Member of Technical Staff | +1.781.442.2037 <(781)%20442-2037>
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190916/906d825a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190916/906d825a/oracle_sig_logo.gif>