8231254: (fs) Add test for macOS Catalina changes to protect system software

[Brian Burkhalter]

> On Sep 20, 2019, at 7:57 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> 
>> On Sep 20, 2019, at 2:27 AM, Alan Bateman <Alan.Bateman at oracle.com <mailto:Alan.Bateman at oracle.com>> wrote:
>> 
>> On 20/09/2019 01:01, Brian Burkhalter wrote:
>>> :
>>> I added some other tests to check a smattering of NIO API calls applied to locations in both the system (read-only) and data (read-write) volumes. These are in the checkSystemVolume() and checkDataVolume() methods.
>>> 
>>> http://cr.openjdk.java.net/~bpb/8231254/webrev.01/ <http://cr.openjdk.java.net/~bpb/8231254/webrev.01/>
>> The test is no longer a test for FileStore so it probably should be moved to a new location. The file/etc directory might be okay, maybe name it MacVolumesTest?
>> 
>> In checkFirmLinks it would be better to replace L164-165 with Files.newBufferedReader(FIRMLINKS) and use try-with-resources to ensure that it closes the file.
> 
> OK I will make the above changes but not until I have access to a Catalina machine again.

The suggested changes are made in http://cr.openjdk.java.net/~bpb/8231254/webrev.02/.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190920/7d769c23/attachment.html>