8242292: java.nio.file.FileSystems.getFileSystem(URI) should throw IAE if the URI's scheme is null

Brian Burkhalter brian.burkhalter at oracle.com
Wed Apr 8 15:45:35 UTC 2020



> On Apr 7, 2020, at 1:22 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> 
>> On Apr 7, 2020, at 12:24 PM, Alan Bateman <Alan.Bateman at oracle.com <mailto:Alan.Bateman at oracle.com>> wrote:
>> 
>> On 07/04/2020 19:33, Brian Burkhalter wrote:
>>> Please review the change included below to address [1] in hope of shedding some light on [2].
>> The change looks okay as it's an oversight that it throws NPE rather than IAE then the URI doesn't have a scheme. We should probably update one of the existing tests for this case.
> 
> Here’s a version of the patch including a modified, existing test:
> 
> http://cr.openjdk.java.net/~bpb/8242292/webrev.00/ <http://cr.openjdk.java.net/~bpb/8242292/webrev.00/>
> 
> The impl change itself is the same.

Please see http://cr.openjdk.java.net/~bpb/8242292/webrev.01/. Test job in progress.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200408/b48201dc/attachment.htm>


More information about the nio-dev mailing list