RFR: JDK-8241883: (zipfs) SeekableByteChannel:close followed by SeekableByteChannel:close will throw an NPE
Brian Burkhalter
brian.burkhalter at oracle.com
Wed Apr 8 20:20:27 UTC 2020
> On Apr 8, 2020, at 12:36 PM, Lance Andersen <lance.andersen at oracle.com> wrote:
>
>> On Apr 8, 2020, at 6:12 AM, Alan Bateman <Alan.Bateman at oracle.com <mailto:Alan.Bateman at oracle.com>> wrote:
>>
>> On 07/04/2020 21:11, Lance Andersen wrote:
>>> :
>>>
>>> I can look to add some tests going forward as I am not sure we have any existing tests
>>>
>> The close method should be idempotent, also should be thread safe in this zipfs implementation to avoid random exceptions. If I read the proposed fix correctly then it still have timing issues when there are several thread accessing the zip file system, is that correct?
>
>
> Ok, I believe the revised patch below is in line with what you are suggesting:
It looks all right to me.
Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200408/98fec4ee/attachment.htm>
More information about the nio-dev
mailing list