RFR[8246707]: '(sc) SocketChannel.read/write throws AsynchronousCloseException on closed channel'

[Alan Bateman]

On 07/08/2020 17:14, Conor Cleary wrote:
>
> Hi Alan,
>
> Your point about assertThrows was correct, it did not fail when a 
> sub-class of CCE was thrown i.e AsynchronousCloseException. It has 
> therefore been replaced by catching the exception in as a Throwable 
> and comparing it with the desired exception using assertEquals. The 
> correct test behavior was verified by running the tests both with and 
> without the changes to SocketChannelImpl.
>
> Other minor changes were made as per your feedback related to 
> SocketChannelImpl.
>
>   * webrev:
>     http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8246707/webrevs/webrev.06/
>   * bug: https://bugs.openjdk.java.net/browse/JDK-8246707
>
Thanks for the update. The changes to SocketChannelImpl look good except 
the copyright header where you've removed the start date.

The test is mostly okay too but might be clearer to rename the listener 
socket to "listener" rather than "sr".

-Alan.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200807/12e7c516/attachment.htm>