RFR 8245194: Unix domain socket channel implementation

[Alan Bateman]

On 24/08/2020 10:58, Michael McMahon wrote:
>
> Thanks for the review. Just on the Win32 variant, getPathForWin32Calls 
> seems to return a Unicode/wide character string, but the windows API 
> expects UTF-8. Also, it normalizes the path including converting to 
> absolute form. (Haven't checked, but maybe getByteArrayForSysCalls 
> does that too). But, we need to support relative paths in this API, 
> given the severe constraints on the length of Unix domain socket 
> names. There probably is still an issue with the right character set 
> being used. So, I will look into fixing that (maybe by adding suitable 
> methods to WindowsPath and UnixPath if necessary).
The UnixPath implementation uses relative paths, except for the corner 
case where user.dir isn't the working directory. Windows is more 
complicated because of long paths and other reasons. It Windows has the 
same 100 byte or char limit then it just limits the addressing. I'm 
surprised it uses UTF-8 when the Win32 uses Unicode (at least for the W 
variants). I see you have updated webrev on this and I will try to get 
to that soon.

-Alan.