RFR: 8257966: Instrument test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/StateTestService.java [v2]
Michael McMahon
michaelm at openjdk.java.net
Thu Dec 10 12:32:36 UTC 2020
On Thu, 10 Dec 2020 12:04:58 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Michael McMahon has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - updated and working, ready for review again
>> - intermediate non functioning state
>
> test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/StateTestService.java line 75:
>
>> 73: try {
>> 74: Path path = Path.of(logDir, "statetest.txt");
>> 75: FileOutputStream f = new FileOutputStream(path.toFile(), true);
>
> This appends, is that intended? You could use Files.newOutputStream here to avoid the lossy conversion to File.
Yes, there are multiple calls to StateTestService in the one test. So, they would be all overwritten by the last one.
I had made the PR draft so I didn't realise there would be update notifications. But, thanks for the comments anyway. I will update and then re-open the review.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1714
More information about the nio-dev
mailing list