RFR: 8257966: Instrument test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/StateTestService.java [v4]
Daniel Fuchs
dfuchs at openjdk.java.net
Thu Dec 10 15:29:35 UTC 2020
On Thu, 10 Dec 2020 13:10:48 GMT, Michael McMahon <michaelm at openjdk.org> wrote:
>> Could I get the following small (temporary) test change reviewed please?
>>
>> It adds some printlns to a file from a process launched by the inetd/launch simulator in the regression tests.
>> Normal stderr, stdout is not available in that context.
>>
>> Thanks,
>> Michael.
>
> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>
> removed unneeded import
This looks reasonable to me too. The only strange thing is having the log file in the `test.classes` directory, I would expect to have it in the `user.dir` instead (the scratch directory created by jtreg for the test, which is also the current working directory).
-------------
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1714
More information about the nio-dev
mailing list