RFR(8u): 8229872: (fs) Increase buffer size used with getmntent

[Andrew Hughes]

On 28/10/2019 09:20, Vladimir Kempik wrote:
> Hello
> Can anyone please take a look at this patch?
> The difference between 11 and 8 is pretty simple: move one method from superclass to subclass to prevent it being compiled on every Unix system(it can’t be compiled on solaris). This code is only used on Linux so far.
> 
> Thanks, Vladimir
> 
> 21 окт. 2019 г., в 19:23, Hohensee, Paul <hohensee at amazon.com<mailto:hohensee at amazon.com>> написал(а):
> 
> +jdk8u-dev
> 
> Paul
> 
> From: nio-dev <nio-dev-bounces at openjdk.java.net<mailto:nio-dev-bounces at openjdk.java.net>> on behalf of Vladimir Kempik <vkempik at azul.com<mailto:vkempik at azul.com>>
> Date: Monday, October 21, 2019 at 2:47 AM
> To: "nio-dev at openjdk.java.net<mailto:nio-dev at openjdk.java.net>" <nio-dev at openjdk.java.net<mailto:nio-dev at openjdk.java.net>>
> Subject: RFR(8u): 8229872: (fs) Increase buffer size used with getmntent
> 
> Hello
> 
> Please review backport of https://bugs.openjdk.java.net/browse/JDK-8229872 to 8u:
> http://cr.openjdk.java.net/~vkempik/8229872/ojdk8/webrev.00/
> 
> Difference between 14/13/11 fix: getline is missing on solaris10, so getlinelen method was moved from UnixNativeDispatcher to LinuxNativeDispatcher.
> Original fix: https://hg.openjdk.java.net/jdk/jdk/rev/2d40e6a7ce8e
> 
> Such fix was already included into azul’s october psu for openjdk8 and passed all release cycle tests.
> 
> Thanks, Vladimir
> 

An addition to the comments above getlinelen in LinuxNativeDispatcher.c
as to why it is located there rather than in UnixNativeDispatcher.c
would be good for anyone trying to understand this difference in future
(no need for a new webrev, just add before push).

Approved for 8u.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200218/907d016c/signature-0001.asc>