[8u] RFR: 8216472: (se) Stack overflow during selection operation leads to crash (win)

[Andrew Hughes]

On 19/02/2020 11:42, Alex Kashchenko wrote:
> Please review the backport of JDK-8216472 to 8u:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8216472
> 
> Original review thread:
> https://mail.openjdk.java.net/pipermail/nio-dev/2019-October/006684.html
> 
> Original review thread (continuation):
> https://mail.openjdk.java.net/pipermail/nio-dev/2019-November/006777.html
> 
> Original change: https://hg.openjdk.java.net/jdk/jdk/rev/6bc29ebe053e
> 
> 11u review thread:
> http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-January/002417.html
> 
> 
> 11u change: https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/3f41514eef8a
> 
> 8u webrev: http://cr.openjdk.java.net/~akasko/jdk8u/8216472/webrev.00/
> 
> 8u change is the same as in 11u, it doesn't apply cleanly to 8u because
> of different imports and minor code differences in java part.
> 
> Testing: 8u change in this form was included with Red Hat 8u242-windows
> release and passed usual release testing.
> 

This looks good to me.

I'd still say you should use your OpenJDK username on this commit, even
if you're not technically an author for this particular JDK project.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200220/3dc0b539/signature.asc>