8236582: (fc) FileChannel.map fails with InternalError when security manager enabled

Brian Burkhalter brian.burkhalter at oracle.com
Tue Jan 7 18:19:08 UTC 2020



> On Jan 7, 2020, at 7:55 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 07/01/2020 15:44, Brian Burkhalter wrote:
>> This issue [1] is caused by using privateLookupIn() outside a privileged block. The patch [2] fixes this. The added test fails without the source patch but passes with it.
>> 
> Thanks for picking this up, it's a small regression from JEP 352. The change to ExtendedMapMode looks good. I think the test should be in the FileChannel directory with the other tests for FileChannel.map.

Agreed. Maybe the test could have a better name, too.

> The test should close the FileChannel (try-with-resources should be best here).

Above fixed here: http://cr.openjdk.java.net/~bpb/8236582/webrev.01/ <http://cr.openjdk.java.net/~bpb/8236582/webrev.01/>

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200107/58d62a5e/attachment.htm>


More information about the nio-dev mailing list