8236804: java/nio/channels/FileChannel/MapWithSecurityManager.java should be run in othervm mode

[Chris Hegarty]

Thanks Brian. Reviewed.

-Chris.

> On 8 Jan 2020, at 18:22, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> https://bugs.openjdk.java.net/browse/JDK-8236804 <https://bugs.openjdk.java.net/browse/JDK-8236804> following up on the comments below.
> 
> Diff:
> 
> --- a/test/jdk/java/nio/channels/FileChannel/MapWithSecurityManager.java
> +++ b/test/jdk/java/nio/channels/FileChannel/MapWithSecurityManager.java
> @@ -24,6 +24,7 @@
>  /* @test
>   * @bug 8236582
>   * @summary Tests the map method when running with a security manager
> + * @run main/othervm MapWithSecurityManager
>   */
> 
> Thanks,
> 
> Brian
> 
>> On Jan 8, 2020, at 8:44 AM, Brian Burkhalter <brian.burkhalter at oracle.com <mailto:brian.burkhalter at oracle.com>> wrote:
>> 
>>> On Jan 8, 2020, at 4:20 AM, Chris Hegarty <chris.hegarty at oracle.com <mailto:chris.hegarty at oracle.com>> wrote:
>>> 
>>>> So modified: http://cr.openjdk.java.net/~bpb/8236582/webrev.02/ <http://cr.openjdk.java.net/~bpb/8236582/webrev.02/>.
>>> 
>>> The source changes look good.
>>> 
>>> The test should be run in othervm mode, since it depends on triggering
>>> the loading of ExtendedMapMode when a security manager is present -
>>> which is not guaranteed to be the case as the test stands. For example,
>>> the test passes ( without the fix ) when I run it with all the other
>>> tests in test/jdk/java/nio/channels/FileChannel/ and `-conc:1 -agentvm`
>>> - since ExtendedMapMode is loaded from a previous test run in the same
>>> agent.
>>> 
>>>   * @run main/othervm MapWithSecurityManager
>> 
>> Oops, already pushed before I saw this message. I guess I’ll open another issue to make the change to the test.
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200108/a4f95b98/attachment-0001.htm>