[14] 8230665: (bf spec) ByteBuffer::alignmentOffset spec misleading when address is misaligned

Paul Sandoz paul.sandoz at oracle.com
Tue Jan 14 01:59:46 UTC 2020


+1

Paul.

> On Jan 13, 2020, at 4:44 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> 
>> On Jan 13, 2020, at 8:49 AM, Brian Burkhalter <brian.burkhalter at oracle.com <mailto:brian.burkhalter at oracle.com>> wrote:
>> 
>>> On Jan 11, 2020, at 12:10 AM, Alan Bateman <Alan.Bateman at oracle.com <mailto:Alan.Bateman at oracle.com>> wrote:
>>> 
>>> The spec/impl looks good. The tests for alignmentOffset are in open/test/java/nio/ByteBuffer so better to keep them in one place if possible.
>> 
>> Are you suggested simply to move the test as-is or incorporate the testing into, e.g., BasicByte?
> 
> Here [1] is a version which puts the new test code into existing files.
> 
> Thanks,
> 
> Brian
> 
> [1] http://cr.openjdk.java.net/~bpb/8230665/webrev.01/ <http://cr.openjdk.java.net/~bpb/8230665/webrev.01/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200113/5674e363/attachment.htm>


More information about the nio-dev mailing list