[15] 8220816: Files.createDirectory should make it more obvious that it fails when the directory already exists

Lance Andersen lance.andersen at oracle.com
Fri Jan 24 22:46:31 UTC 2020


Hi Brian,

I understand what you are trying to clarify but I think it is still needs some wordsmithing:

——————
failing if the directory already exists. 

—————————

The exception is thrown if the  entry specified for “dir” exists  so the entry could be a file or a directory

Perhaps something along the lines of:

	 “An exception will be thrown if the specified Path already exists”


Or something like that as that will cover the case of a file or directory.


HTH

BEst
Lance

> On Jan 24, 2020, at 5:21 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> Please review this minor change [1] to address [2]. If it looks worthwhile to address then a CSR will be filed.
> 
> Thanks,
> 
> Brian
> 
> [1] http://cr.openjdk.java.net/~bpb/8220816/webrev.00/
> [2] https://bugs.openjdk.java.net/browse/JDK-8220816

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200124/c76d0b83/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200124/c76d0b83/oracle_sig_logo.gif>


More information about the nio-dev mailing list