8219014: (bf) Add absolute bulk put methods which accept a source Buffer

Alan Bateman Alan.Bateman at oracle.com
Sat Jul 4 15:11:58 UTC 2020


On 02/07/2020 21:15, Brian Burkhalter wrote:
> I have attached a specdiff to the CSR [1].
>
This method does overlap a bit with MemorySegment but I think it's 
okay.  The wording in the javadoc is good. The existing absolute 
operations use "index" rather than "offset" so I think you'll have to 
rename the parameters for the source region to "srcIndex" and 
"srcLength" to keep the naming consistent.

Minor nit in the patch is that the naming for the parameters to the 
non-public putBuffer are also inconsistent. Also would be good to keep 
the style @param/@return/@throws consistent rather brining a different 
style into the templates.

There aren't any tests in webrev.02, are these coming for the next round?

-Alan


More information about the nio-dev mailing list