RFR 8245194: Unix domain socket channel implementation

[Michael McMahon]

Hi Chris,

Thanks for the review.

On 16/07/2020 20:08, Chris Hegarty wrote:
>
>> On 16 Jul 2020, at 15:49, Michael McMahon <michael.x.mcmahon at oracle.com> wrote:
>> ...
>>
>> [1] http://cr.openjdk.java.net/~michaelm/8245194/api.webrev/webrev.4/
>>
>> [2] http://cr.openjdk.java.net/~michaelm/8245194/impl.webrev/webrev.4/
>>
>> [3] http://cr.openjdk.java.net/~michaelm/8245194/specdiff/specout.4/overview-summary.html
>>
> 1) I’d still like to see "an unnamed UnixDomainSocketAddress" used instead of "UnixDomainSocketAddress with an empty path” - since we have a nice definition of _unnamed_ already.
Right, I meant to change that. Will do.
> 2) I wonder if we can add the following definitions:
>
>    “channel for an Internet protocol socket”  - channel::getProtocolFamily returns one of INET or INET6
>
>    “channel for a Unix domain socket” - channel::getProtocolFamily returns UNIX

I have re-organised the package level description to clearly put the 
definitions first, before they are referred to and have incorporated 
references to getProtocolFamily there too. Take a look and see what you 
think.

I have added a new revision of the webrevs/specdiffs including these and 
Daniel's comments at:

[1] http://cr.openjdk.java.net/~michaelm/8245194/api.webrev/webrev.5/

[2] http://cr.openjdk.java.net/~michaelm/8245194/impl.webrev/webrev.5/

[3] http://cr.openjdk.java.net/~michaelm/8245194/specdiff/specout.5/overview-summary.html

Thanks,

Michael

> -Chris.