RFR 8245194: Unix domain socket channel implementation

[Daniel Fuchs]

Hi Michael,

On 17/07/2020 11:57, Michael McMahon wrote:
> Hi Daniel,
>> Maybe a sub-section "About UNIX domain" - similar to "About IPv6",
>> in either one of these two sections?
>>
> 
> I'm not sure. The package level docs for java.net don't mention
> SocketAddress or InetSocketAddress either. Maybe it should have a paragraph
> like that but I feel it's out of scope for this work.
> 
> I notice that there is no equivalent explanation relating to 
> StandardProtocolFamily
> which is also only used in NIO. Maybe both of these could be addressed 
> in another doc update?

I'll let you be the judge for that - it was just a suggestion,
prompted by the fact that UnixDomainSocketAddress is listed
in the classes section below - which could give the wrong
impression that Socket & friends might support it.

>> http://cr.openjdk.java.net/~michaelm/8245194/specdiff/specout.4/java.base/java/net/package-summary.html 
>>
>>
>> Similarly - maybe UnixDomainSocketAddress could have an @see
>> pointing to the SocketChannel and ServerSocketChannel?
>>
> 
> I agree that is a simple change, which would be useful.

And maybe that's enough.

>> In 
>> http://cr.openjdk.java.net/~michaelm/8245194/specdiff/specout.4/java.base/java/nio/channels/ServerSocketChannel.html 
>>
>> two args bind method > How about rewording as:
> 
>       * @throws  SecurityException
>       *          If a security manager has been installed and its {@link
>       *          SecurityManager#checkListen checkListen} method denies
>       *          the operation for an <i>Internet protocol</i> socket 
> address,
>       *          or for a <i>Unix domain</i> socket address if it denies
>       *          {@link NetPermission}{@code("allowUnixDomainChannels")}.

That sounds right. Thanks. I like this wording much better.

best regards,

-- daniel