RFR 8245194: Unix domain socket channel implementation

Michael McMahon michael.x.mcmahon at oracle.com
Fri Jul 17 16:36:52 UTC 2020


On 17/07/2020 16:54, Chris Hegarty wrote:
> Michael,
>
>> On 17 Jul 2020, at 15:57, Michael McMahon <michael.x.mcmahon at oracle.com> wrote:
>>
>> ...
>>
>> [3] http://cr.openjdk.java.net/~michaelm/8245194/specdiff/specout.5/overview-summary.html
>>
> The API looks very good to me.
>
> A final minor picky comment:
>
> * UnixDomainSocketAddress::equals should probably specify that
>    two addresses are equal if their paths ( getPath() ) are equal.
>
> -Chris.

Do you think the @return is not sufficient?

      * @return true if the path fields are equal

- Michael



More information about the nio-dev mailing list