RFR 8245194: Unix domain socket channel implementation

Alan Bateman Alan.Bateman at oracle.com
Mon Jul 27 07:24:00 UTC 2020


On 21/07/2020 12:58, Michael McMahon wrote:
> Alan
>
> I have updated the API webrev [1]
>
> [1] http://cr.openjdk.java.net/~michaelm/8245194/api.webrev/webrev.6/
I did another pass over the latest webrev for the API changes (webrev.6) 
and overall it is looking very good.

One thing that I think needs another iteration is the package 
description as the text is a bit of out place. If we are adding text 
about network channels then it would be better to put it in section 
further up that has the table of for selectable channels. This would 
keep the flow and avoids having text for selectable channels in two 
places. The reference to the legacy java.net.preferIPv4Stack system 
property also looks out of place. Maybe we can just put an @see in the 
static open methods instead? There are also a bunch of imports into 
package-info that I assume are left over from previous iterations.

A minor nit in the wording is that SC.connect throws 
UnresolvedAddressException. I think it would be more correct to say 
"that is not fully resolved".

-Alan


More information about the nio-dev mailing list