RFR 8245194: Unix domain socket channel implementation
Chris Hegarty
chris.hegarty at oracle.com
Fri Jul 31 12:30:01 UTC 2020
Michael,
> On 29 Jul 2020, at 18:11, Michael McMahon <michael.x.mcmahon at oracle.com> wrote:
>
> Alan,
>
> I have incorporated your comments in a .7 version of the review
>
> http://cr.openjdk.java.net/~michaelm/8245194/api.webrev/webrev.7/
>
> http://cr.openjdk.java.net/~michaelm/8245194/impl.webrev/webrev.7/
>
> http://cr.openjdk.java.net/~michaelm/8245194/specdiff/specout.7/overview-summary.html
>
I think that this looks very good, as is.
Thanks for experimenting with the API point to expose the protocol family of the channel’s socket. It didn’t seem to provide the tightening of the spec that I expected, and I can see that you did quite a good job with the textual definitions in the package description - this may be sufficient for now, but FTR I will note that it is not possible to always determine the protocol family of a channel, and it is never possible without explicit permissions being granted ( hmm.. how does one assert minimal permissions when invoking getLocalAddress if the protocol family is unknown ). Anyway, this can be revisited later if needed.
-Chris.
More information about the nio-dev
mailing list