8247463: [TESTBUG] java/nio/channels/etc/OpenAndConnect.java fails due to IPv6 not available(Internet mail)

jiefu(傅杰) jiefu at tencent.com
Sat Jun 13 06:36:36 UTC 2020


Hi Alan,

Thanks for your review.

What do you think of this one: http://cr.openjdk.java.net/~jiefu/8247463/webrev.02/

Thanks a lot.
Best regards,
Jie

On 2020/6/12, 10:01 PM, "nio-dev on behalf of Alan Bateman" <nio-dev-bounces at openjdk.java.net on behalf of Alan.Bateman at oracle.com> wrote:

    On 12/06/2020 13:58, Daniel Fuchs wrote:
    > Hi Jie,
    >
    > One more step :-)
    >
    > It looks to me as if several cases are misplaced. For instance:
    >
    >  159             {   INET6,  IA6ANYLOCAL,   null,    IA6LOOPBACK },
    >  160             {   INET6,  IA6ANYLOCAL,   INET6,   IA6LOOPBACK },
    >  162             {   null,   IA6ANYLOCAL,   null,    IA6LOOPBACK },
    >  164             {   null,   IA6ANYLOCAL,   INET6,   IA6LOOPBACK },
    >  181             {   null,   IA4LOOPBACK,   INET6,   IA6ANYLOCAL },
    >  182             {   null,   IA6LOOPBACK,   INET6,   IA6ANYLOCAL },
    >  183             {   null,   IA6LOOPBACK,   null,    IA6ANYLOCAL },
    >  184             {   null,   IA4LOOPBACK,   null,    IA6ANYLOCAL }
    >
    > don't require that IA6LOCAL is configured. So they could be tested
    > even if IA6LOCAL is null.
    Also, the check for hasIPv4 and IPv6 should be in the data provider, not 
    the consumer of the data provider.
    
    -Alan
    



More information about the nio-dev mailing list