4617266: (se spec) SelectionKey.OP_READ/OP_WRITE documentation errors

Lance Andersen lance.andersen at oracle.com
Thu Mar 5 18:38:22 UTC 2020


Hi Brian,

This reads OK and should have a CSR

Best
Lance

> On Mar 5, 2020, at 12:35 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> For [1] please review this minor change [2] which would also I suppose necessitate a CSR.
> 
> Thanks,
> 
> Brian
> 
> [1] https://bugs.openjdk.java.net/browse/ <https://bugs.openjdk.java.net/browse/>JDK-4617266
> [2] diff --git a/src/java.base/share/classes/java/nio/channels/SelectionKey.java b/src/java.base/share/classes/java/nio/channels/SelectionKey.java
> 
> @@ -73,7 +73,7 @@
>   *
>   * <p> This class defines all known operation-set bits, but precisely which
>   * bits are supported by a given channel depends upon the type of the channel.
> - * Each subclass of {@link SelectableChannel} defines an {@link
> + * Each subclass of {@link SelectableChannel} defines a {@link
>   * SelectableChannel#validOps() validOps()} method which returns a set
>   * identifying just those operations that are supported by the channel.  An
>   * attempt to set or test an operation-set bit that is not supported by a key's
> @@ -290,7 +290,7 @@
>       * {@code OP_READ} at the start of a <a
>       * href="Selector.html#selop">selection operation</a>.  If the selector
>       * detects that the corresponding channel is ready for reading, has reached
> -     * end-of-stream, has been remotely shut down for further reading, or has
> +     * end-of-stream, has been remotely shut down for further writing, or has
>       * an error pending, then it will add {@code OP_READ} to the key's
>       * ready-operation set.  </p>
>       */
> @@ -303,7 +303,7 @@
>       * {@code OP_WRITE} at the start of a <a
>       * href="Selector.html#selop">selection operation</a>.  If the selector
>       * detects that the corresponding channel is ready for writing, has been
> -     * remotely shut down for further writing, or has an error pending, then it
> +     * remotely shut down for further reading, or has an error pending, then it
>       * will add {@code OP_WRITE} to the key's ready set.  </p>
>       */
>      public static final int OP_WRITE = 1 << 2;
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200305/ad5a39c5/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200305/ad5a39c5/oracle_sig_logo-0001.gif>


More information about the nio-dev mailing list