RFR 8241305: Add protocol specific factory creation methods to SocketChannel and ServerSocketChannel

[Michael McMahon]

On 16/05/2020 15:43, Alan Bateman wrote:
> On 16/05/2020 09:06, Michael McMahon wrote:
>>
>> I don't follow this. The reason for the UOE rows are to test for UOE 
>> being thrown when IPv6 is not
>> available. Are you saying not to test this scenario?
> The xxOpen tests will test that UOE is thrown by the open methods.
>
> I'm just pointing out that the test parameters generated for the 
> xxOpenBind tests will test the same thing. If you delete L170-172 from 
> the openBind data provider then it will allow the xxOpenBind tests to 
> be simplified so that they test the bind method. I don't think there 
> is any loss of test coverage because the second parameter is 
> completely ignored by the tests that have expectedException=UOE.
>
Right, got you now.
>>
>>> :
>>>
>>> e they needed? I assume openConnect just need to tests that use IPv4 
>>> local addresses when IA4LOCAL != null.
>>>
>> I'm assuming the truncated word refers to previous sentence.
> Sorry about that, the comment was further down and related to the 
> naming issues. If IA4LOCAL and IA6LOCAL are tested for null then it 
> will allow has_ia4local and has_ia6local to go away.
>
>
OK
>> :
>>
>> How about adding the suffix "Tests" to the names, eg 
>> openConnectV4LocalTests?
> Might be clearer with "gen" or "generate" as they generate test cases, 
> up to you.
>
gen is already part of the name for one of the lists. So, I left it as 
Tests. If you
have a strong preference for something different, I'll change it.

New webrev is at: http://cr.openjdk.java.net/~michaelm/8241305/webrev.6/

Thanks,

Michael.