8245121: (bf) XBuffer.put(Xbuffer src) can give unexpected result when storage overlaps

[Brian Burkhalter]

New version uploaded here [1]. This includes the doc change outlined in the CSR [2] and the changes mentioned below.

> On May 26, 2020, at 2:27 PM, Paul Sandoz <paul.sandoz at oracle.com> wrote:
> 
>>> I would be inclined to drop the Bits.JNI_COPY_TO_ARRAY_THRESHOLD, since it never applies to direct buffers. I bet the swapping. Maybe can be determined with follow evaluation after this issue.
>> 
>> You mean dropping the else branch and converting the else if branch to an else?
>> 
> 
> Yes.

Done in this update.

> 
> […]
> 
>>> I still hold out hope you can convert it to a testng test, with data providers and asserts, this is all good common practice for writing tests. The nested loops in test() effectively capture the test combinations input for two test cases. Let me know if you need some advice/help on this.
>> 
>> I’ll take another look.

I took a stab at changing the test to use DataProviders and Asserts in this update.

Thanks,

Brian

[1] http://cr.openjdk.java.net/~bpb/8245121/webrev.02/
[2] https://bugs.openjdk.java.net/browse/JDK-8245866
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200528/d97166dc/attachment.htm>