RFR: 8255758: JEP 380 spec clarifications

Daniel Fuchs dfuchs at openjdk.java.net
Thu Nov 5 10:23:03 UTC 2020


On Mon, 2 Nov 2020 22:04:56 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

> Minor spec changes from spec approved in initial CSR

Marked as reviewed by dfuchs (Reviewer).

src/java.base/share/classes/java/net/doc-files/net-properties.html line 250:

> 248: Automatic binding of a server socket occurs when {@link 
> 249: java.nio.channels.ServerSocketChannel#bind(SocketAddress,int) ServerSocketChannel.bind}
> 250: is called with a {@code null} address parameter. In this case, the system

doesn't it also happen when it is called with a UnixDomainSocketAddress that has an empty path?

src/java.base/share/classes/java/net/doc-files/net-properties.html line 246:

> 244: <H2>Unix domain sockets</H2>
> 245: <P>There are a number of system (and networking) properties that affect the behavior of
> 246: channels to <i>Unix domain</i> server sockets when binding <i>automatically</i>.

Should this also mention <i>implicit</i> binding?

src/java.base/share/classes/java/net/doc-files/net-properties.html line 252:

> 250: is requested to choose a unique path for the socket in some predefined system temporary
> 251: directory.
> 252: <P>There are a number of system (and networking) properties that affect the behavior of

nit: `<p>` (lowercase and on a single line to match the style elsewhere)

src/java.base/share/classes/java/net/doc-files/net-properties.html line 271:

> 269: 	are set, then some systems (eg Windows)  may check a commonly used environment 
> 270: 	variable as temporary directory.
> 271: 	<LI><P><B>{@systemProperty java.io.tmpdir}</b> If the previous step fails to locate

nit again (two places): `<LI><P><B>` should probably be `<li><p><b>` especially since the `<B>` tag is closed with `</b>`

-------------

PR: https://git.openjdk.java.net/jdk/pull/1021


More information about the nio-dev mailing list