RFR: 8256146: Cleanup test/jdk/java/nio/channels/DatagramChannel/Connect.java [v2]

Daniel Fuchs dfuchs at openjdk.java.net
Fri Nov 13 17:05:17 UTC 2020


> Hi,
> 
> Please find here a trivial cleanup change for  test/jdk/java/nio/channels/DatagramChannel/Connect.java
> The change caters for possible evolution of the test - if we ever decided to bind the Reactor to the wildcard address;
> (the reactor is currently bound to the loopback).
> 
> I would usually not bother but I had this experiment in my local workspace: it could as well be pushed as it cleans up the Actor logic which no longer has to depend on the fact that the Reactor is not bound to the wildcard.

Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - 8256146: Cleanup test/jdk/java/nio/channels/DatagramChannel/Connect.java
   
   Integrated review comments.
 - Merge
 - 8256146: Cleanup test/jdk/java/nio/channels/DatagramChannel/Connect.java

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1144/files
  - new: https://git.openjdk.java.net/jdk/pull/1144/files/c884adb0..253d2ccc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1144&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1144&range=00-01

  Stats: 23220 lines in 438 files changed: 13605 ins; 6615 del; 3000 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1144.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1144/head:pull/1144

PR: https://git.openjdk.java.net/jdk/pull/1144


More information about the nio-dev mailing list