RFR: 8254692: (se) Clarify the behaviour of the non-abstract SelectorProvider::inheritedChannel

Alan Bateman alanb at openjdk.java.net
Tue Oct 20 07:09:32 UTC 2020


On Mon, 19 Oct 2020 18:22:17 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:

> Please review this fix to provide spec clarity on the default implementation of
> java.nio.channels.spi.SelectorProvider::inheritedChannel() method which simply returns “null”, and a test for it.
> Please review the corresponding CSR as well: https://bugs.openjdk.java.net/browse/JDK-8254848

test/jdk/java/nio/channels/etc/ProtocolFamilies.java line 47:

> 45: /*
> 46:  * @test
> 47:  * @bug 8254692

test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel would be a more appropriate location to test this.

I assume you modified etc/ProtocolFamilies.java you because it has a custom provider that doesn't override this method
but this test has the summary "Test SocketChannel, ServerSocketChannel and DatagramChannel with various ProtocolFamily
combinations" so not really the right place.

-------------

PR: https://git.openjdk.java.net/jdk/pull/745


More information about the nio-dev mailing list