RFR: 8254692: (se) Clarify the behaviour of the non-abstract SelectorProvider::inheritedChannel

Alan Bateman alanb at openjdk.java.net
Tue Oct 20 15:54:17 UTC 2020


On Tue, 20 Oct 2020 09:04:01 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> ProtocolFamilies/testCustomProvider exercises the methods that take a protocol family, it's not really the right place
>> to exercise the inheritedChannel method. Can we add a test to
>> test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel instead?
>
> No disagreement about testCustomProvider not being the most appropriate place to test the default implementation of
> inheritedChannel. What I was suggesting was to move *all* the assertions related to the default implementation of
> SelectorProvider to a single new test located under test/jdk/java/nio/channels/spi/SelectorProvider/, rather than
> splitting the tests for the default implementation across several different tests and directory hierarchies.

A new test/jdk/java/nio/channels/spi/SelectorProvider that covers all the assertions would be great, thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/745


More information about the nio-dev mailing list