RFR: 8254692: (se) Clarify the behaviour of the non-abstract SelectorProvider::inheritedChannel [v3]

Alan Bateman alanb at openjdk.java.net
Wed Oct 21 07:22:15 UTC 2020


On Tue, 20 Oct 2020 18:43:31 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:

>> Please review this fix to provide spec clarity on the default implementation of
>> java.nio.channels.spi.SelectorProvider::inheritedChannel() method which simply returns “null”, and a test for it.
>> Please review the corresponding CSR as well: https://bugs.openjdk.java.net/browse/JDK-8254848
>
> Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
> 
>   replace general static import to a more specific one

Thanks for the new test. SelectorProvider has 3 non-abstract methods and the coverage looks good.
"TestDefaultImplementation" might be a better name for the test but otherwise looks good.

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/745


More information about the nio-dev mailing list