RFR: 8247614: java/nio/channels/DatagramChannel/Connect.java timed out [v3]
Conor Cleary
ccleary at openjdk.java.net
Tue Oct 27 11:24:20 UTC 2020
On Mon, 26 Oct 2020 15:23:50 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Conor Cleary has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8247614: Threadpool passed to invoke
>
> test/jdk/java/nio/channels/DatagramChannel/Connect.java line 82:
>
>> 80: final DatagramChannel dc;
>> 81:
>> 82: Actor(int port) throws IOException {
>
> I think it would be clear to create Actor with a SocketAddress rather than a port. It didn't matter in the old test because the Reactor was bound to the wildcard address but here there is nothing to tell the Actor which address to connect it.
Thanks for the feedback Alan! Will look into these comments presently
-------------
PR: https://git.openjdk.java.net/jdk/pull/679
More information about the nio-dev
mailing list