RFR: 8255576: (fs) Files.isHidden() throws ArrayIndexOutOfBoundsException (unix)

Sat Oct 31 05:19:55 UTC 2020

On Fri, 30 Oct 2020 18:07:23 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> For the test then I don't think we need to catch AIOOB, the test should fail if any exception is thrown.

Okay, I'll change the catch clause to throw on any `RuntimeException` caught. Or is it also fine to omit the try-catch statements and not provide a specific failure message?

> ... scenario where it would be sensible to run the tests when in a hidden directory ...

What about testing that new scenario additionally to the plain one passing an empty `Path`?

That new scenario would include:
  - create a hidden directory in platform-agnostic manner
  - start a test program using this directory as the working directory
  - assert (by checking the output of the test program?) isHidden returned false

-------------

PR: https://git.openjdk.java.net/jdk/pull/952