RFR: 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed
Brian Burkhalter
bpb at openjdk.java.net
Thu Apr 1 16:45:11 UTC 2021
On Thu, 1 Apr 2021 16:35:10 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>>> I was not able to test that case yet. Using the VolumeInformation was intended to limit spurious equality.
>>>
>>> Can you explain abut DRIVE_REMOTE?
>>
>> I think the volume type will be DRIVE_REMOTE when the root is a UNC (the constants for the volume types are defined in WIndowsConstants). I'm not 100% sure if the server and share names should be compared with or without regard to case so I think we have a bit more exploration to do there. The DRIVE_FIXED case is clear, and it would be good to at least get that fixed as there has been C:\ vs. c:\ confusion in a number of bug reports.
>
> Based on testing in a Win 10 VM, the volume type is in fact DRIVE_REMOTE. The volume serial number however is zero. From what I can test via testing and reading the server and share names don't care about case.
If we are unsure, for UNC, perhaps the server and share name comparisons can remain case sensitive but the file path component comparison be case insensitive?
-------------
PR: https://git.openjdk.java.net/jdk/pull/3279
More information about the nio-dev
mailing list