RFR: 8264200: java/nio/channels/DatagramChannel/SRTest.java fails intermittently

Daniel Fuchs dfuchs at openjdk.java.net
Tue Apr 6 14:49:28 UTC 2021


On Tue, 6 Apr 2021 14:43:13 GMT, Conor Cleary <ccleary at openjdk.org> wrote:

>> As the test is for Datagram send and receive all the data is in byte arrays or equivalent.
>> The entire test could be written using only byte arrays (no Strings, Charsets or conversions) and omit that possibility of confusion about what the test is doing.
>> (And there's no need to change anything).
>
> Alright then so I will continue to to just use `US_ASCII` in this test as "hello" is mappable with it. Encoding and Decoding the string will be done with `US_ASCII`. Appreciate the feedback guys, thanks!

Thanks Conor. Yes - we could work with byte arrays but strings are easier to print & log & more human friendly...

-------------

PR: https://git.openjdk.java.net/jdk/pull/3354


More information about the nio-dev mailing list