RFR: 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed [v5]

Alan Bateman alanb at openjdk.java.net
Fri Apr 9 06:21:27 UTC 2021


On Thu, 8 Apr 2021 19:56:24 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Please consider this change to make `sun.nio.fs.WindowsFileStore.equals()` return `true` if the root strings of the two objects are equal under case insensitive comparison, and the two `WindowsFileStore`s have the same volume information.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8264400: Don't initialize hashCode; use Path.of() in test

Marked as reviewed by alanb (Reviewer).

test/jdk/java/nio/file/FileStore/Basic.java line 87:

> 85:              * Test: FileStore.equals() should not be case sensitive
> 86:              */
> 87:             FileSystem fs = FileSystems.getDefault();

I assume this line is no longer needed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3279


More information about the nio-dev mailing list