RFR: 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed [v6]
Brian Burkhalter
brian.burkhalter at oracle.com
Mon Apr 12 22:29:03 UTC 2021
On Apr 9, 2021, at 11:46 PM, Alan Bateman <alanb at openjdk.java.net<mailto:alanb at openjdk.java.net>> wrote:
On Fri, 9 Apr 2021 22:24:03 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org<mailto:github.com+741251+turbanoff at openjdk.org>> wrote:
Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
8264400: Remove vestigial FileSystems.getDefault()
src/java.base/windows/classes/sun/nio/fs/WindowsFileStore.java line 257:
255: root.toLowerCase(Locale.ROOT).hashCode() : root.hashCode();
256: }
257: return hashCode;
As I know, to make data race benign, field should be read only once. But there is second read which can still return `0`
You can are right, missed in the final review (as this one went through many iter
Filed JDK-8265100 to address this oversight.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20210412/af4c4863/attachment.htm>
More information about the nio-dev
mailing list