RFR: 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821

Daniel D.Daugherty dcubed at openjdk.java.net
Wed Apr 14 19:43:40 UTC 2021


On Wed, 14 Apr 2021 18:28:06 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

> Please review this request to fix a test build failure caused by removing the `isDirectIOSupportedByFS()` method from the test `DirectIOTest` but not removing its use in other tests.
> 
> This also addresses the comment [1] in PR [2] of [3].
> 
> [1] https://github.com/openjdk/jdk/pull/3482#discussion_r613362581
> [2] https://github.com/openjdk/jdk/pull/3482
> [3] https://bugs.openjdk.java.net/browse/JDK-8264821

Thumbs up!

This is a trivial fix and does not need to wait 24 hours.
I sanity checked by searching the repo for `isDirectIOSupportedByFS`
and you've gotten the only remaining references.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3498


More information about the nio-dev mailing list