RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v2]

[Chris Hegarty]

On Wed, 28 Apr 2021 09:06:29 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address first batch of review comments
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/ResourceScope.java line 205:
> 
>> 203:      * until all the resource scope handles acquired from it have been {@link #release(Handle)} released}.
>> 204:      * @return a resource scope handle.
>> 205:      */
> 
> Given recent changes, it might be good to generalise the opening sentence here. Maybe :
>  " Acquires a resource scope handle associated with this resource scope. If the resource scope is explicit ... "   Or some such.

The spec for the acquire method talks only of explicit resource scopes. The comment is suggesting that the spec could be generalised a little, since it is possible to acquire a resource scope handle associated with implicit scopes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3699