RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v3]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Wed Apr 28 20:43:54 UTC 2021


On Wed, 28 Apr 2021 18:33:36 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR contains the API and implementation changes for JEP-412 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment.
>> 
>> [1] - https://openjdk.java.net/jeps/412
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments:
>   * fix typos in javadoc
>   * document ISE being thrown in all methods accepting a scope; add more tests for that

> > test/jdk/jdk/internal/reflect/CallerSensitive/CheckCSMs.java
> 
> Yes that's the test. That test misses to catch your case where aliasing may be possible.



> Yes that's the test. That test misses to catch your case where aliasing may be possible.

To be clear - by aliasing you mean when the @CallerSensitive implementation is called with invokeinterface - so, e.g. doing `MethodHandles.lookup().findVirtual(CLinker.class, ...)` right?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3699


More information about the nio-dev mailing list