RFR: 8265891: (ch) InputStream returned by Channels.newInputStream should override transferTo [v13]
Brian Burkhalter
bpb at openjdk.java.net
Thu Aug 12 08:43:33 UTC 2021
On Wed, 11 Aug 2021 11:27:53 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>>> I think I fixed all requested changes. Anymore comments on this PR?
>>
>> I hope to get to this soon.
>
>> I think I fixed all requested changes. Anymore comments on this PR?
>
> I've looked through the latest revision. Is there any way that we could drop most of the changes to ChannelInputStream and focus on one or two specific cases? I'm asking because there are several issues, inconsistencies, and it is trying to cover many scenarios that aren't covered by the test.
>
> If the original motivation was file -> file then it could be simplified down to a FileChannel -> FileChannel transfer as the default provider uses file channels. We could even push some support into FileChannelImpl so that it is done while holding the position lock.
I do not know exactly what @AlanBateman had in mind, but I think there is general concern about ensuring that all combinations of channel types and all execution paths are exercised.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4263
More information about the nio-dev
mailing list