RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path
Naoto Sato
naoto at openjdk.java.net
Thu Aug 12 18:59:25 UTC 2021
On Thu, 12 Aug 2021 17:43:48 GMT, Lance Andersen <lancea at openjdk.org> wrote:
> Hi all,
>
> Please review the fix for JDK-8263940 to address an issues when the default file system provider is packaged as JAR file on class path.
>
> The patch also addresses the `@bug` line for JDK-8271194
>
> Mach5 Tier1 - Tier3 have run without issues
>
> Best,
> Lance
Looks good to me, Lance.
test/jdk/java/nio/file/spi/SetDefaultProvider.java line 107:
> 105: .map(path -> path.getFileName().toString())
> 106: .filter(f -> f.startsWith("TestProvider"))
> 107: .collect(Collectors.toList());
Nit: Could simply issue `.toList()` here.
-------------
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5103
More information about the nio-dev
mailing list