RFR: 8263940: NPE when creating default file system when default file system provider is packaged as JAR file on class path [v2]

[Alan Bateman]

On Thu, 12 Aug 2021 19:27:42 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review the fix for JDK-8263940 to address an issues when the default file system provider is packaged as JAR file on class path.
>> 
>> The patch also addresses the `@bug` line for JDK-8271194
>> 
>> Mach5 Tier1 - Tier3 have run without issues
>> 
>> Best,
>> Lance
>
> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use toList()

test/jdk/java/nio/file/spi/SetDefaultProvider.java line 26:

> 24: /**
> 25:  * @test
> 26:  * @bug 4313887 7006126 8142968 8178380 8183320 8210112 8266345 8263940

Thanks for correcting the @bug tag.

test/jdk/java/nio/file/spi/SetDefaultProvider.java line 89:

> 87:         createFileSystemProviderJar(jar, Path.of(testClasses));
> 88:         String classpath = jar + File.pathSeparator + testClasses
> 89:                 + File.separator + "modules" + File.separator + "m";

This ends up with two copies of TestFIleSystemProvider on the class path. I think we should compile TestProvider to a different directory. That will eliminate the need to filter the classes when creating the JAR file.

test/jdk/java/nio/file/spi/SetDefaultProvider.java line 99:

> 97:      */
> 98:     private void createFileSystemProviderJar(Path jar, Path dir) throws IOException {
> 99: 

In this test, the supporting methods are at the end of the source file, probably should keep it consistent.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5103