RFR: 8265891: ChannelInputStream.transferTo() uses FileChannel.transferTo()
Markus KARG
github.com+1701815+mkarg at openjdk.java.net
Thu Aug 19 17:20:24 UTC 2021
On Thu, 19 Aug 2021 13:10:25 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> Thanks for the update. I see you've kept the code for the file -> socket scenario but there aren't any tests for this.
Seems I misunderstood your last week's request of separating the PRs! I simply split up the features into several PRs. So you *actually* wanted to start with **just** the FC->FC use case only (which, actually, was not an explicit execution path of the original PR)? I will further narrow this PR then, no problem, just tell me!
And do I understand correctly, you do not just want to have *some* test for each PR that just proofs **the API** is correctly implemented (= Blackbox), but you actually want to have one test for *each existing implementation* of `WriteableByteChannel` (= Whitebox)? I mean, as it is an interface which can be implemented by *infinite* classes by *anybody*, such a request is inherently unresolvable. Or do you just want to have tests for *specific* implementations, then, besides `SocketChannel`, which ones do you want to have tested?
-------------
PR: https://git.openjdk.java.net/jdk/pull/5179
More information about the nio-dev
mailing list