RFR: JDK-8273038: ChannelInputStream.transferTo() uses FileChannel.transferTo(FileChannel) [v7]

Markus KARG github.com+1701815+mkarg at openjdk.java.net
Sun Aug 29 17:15:30 UTC 2021


On Tue, 24 Aug 2021 09:35:25 GMT, pirateskipper <github.com+77050469+pirateskipper at openjdk.org> wrote:

>> Markus KARG has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed whitespace warning
>
> test/jdk/sun/nio/ch/ChannelInputStream/TransferTo.java line 181:
> 
>> 179: 
>> 180:     public static <T extends Throwable> void assertThrows(Thrower thrower, Class<T> throwable, String message) {
>> 181:         Throwable thrown;
> 
> ` Throwable thrown = null;
>         try {
>             thrower.run();`

Is that an OpenJDK best practice or why do you ask for this change? The code actually is a copy of existing OpenJDK code and not originally authored by me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5209


More information about the nio-dev mailing list